Passing page size (width and height) to the OnLoadCompleteListener #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2019
polesapart
pushed a commit
to polesapart/AndroidPdfViewer
that referenced
this pull request
Jul 11, 2020
(merges pull request DImuthuUpe#743)
polesapart
added a commit
to polesapart/AndroidPdfViewer
that referenced
this pull request
Jul 12, 2020
com.github.polesapart This is not meant to claim authorship or whatever, I simply thought it would be required to make publishin in jitpack.io works - but it seems I was mistaken. If there are any reasons I can consider rolling back in the future. Anyway, as the DImuthuUpe#743 broke the ABI slightly, there's no point in being too strict about it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to get the first page real width and height (no canvas) on the OnLoadCompleteListener, to later use in the react-native component https://github.com/wonday/react-native-pdf, Fixes #742